Tag support for Logjam

I took some time this afternoon to add tag support to LogJam. The hardest part was generating the patch because I’m completely unfamiliar with GNU Arch. After an hour of fiddling about, I discovered that tla changes --diff was what I wanted.

I’ve built and tested it; it works. You can get the binary I used here. I doubt it will work unless you have a configuration similar to mine:

 logjam 4.4.1 build configuration:

    - GTK: yes
      - GtkSpell: yes
      - GtkHTML: 3.6
      - librsvg: yes
      - Docklet (“tray icon”): yes
    - Networking: libsoup
    - XMMS helper: yes
    - SQLite3: yes

Plus similar library versions and stuff.

I’ve sent the patch to evan so hopefully it will be included in the next release.

[update: Okay, I've made a proper changeset. You can build your own copy after you've checked out the 4.5 source (directions):
tar xzvf logjam_tags.changeset.tar.gz
tla apply-changeset logjam_tags.changeset/ logjam--dev--4.5--patch-6/
cd logjam--dev--4.5--patch-6/
./autogen.sh
./configure --with-sqlite3
make all
./src/logjam
The SQLite bit is required because there's a problem with journalstore_xml.c I'm not sure what I did that broke it :( ]

[update: quirrc pointed out that servers that don't support tags will return an error and not post (if tags are included). So, I've updated the changeset, patch, and binary so if you don't enter tags, they're not sent to the server if the field is empty. If you fill in the tags field and try to post to a server that doesn't support tags, you'll still get an error "Unknown metadata: taglist" but it's easily correctable.]

(cross-posted to my own journal)